fix: honor Mocha only exclusivity in test harness - #305
Merged
pmatos merged 3 commits intoJul 20, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab6f52191f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Replacing the `it.only = it` alias with a bare exclusive registrar dropped the `.each` helper the alias had carried, so `test.only.each(table)(...)` (global `test` aliases `it`) threw `TypeError: test.only.each is not a function` at registration before exclusivity could apply. Factor the array-table registrar into `eachRegistrar(register)` and attach `it.only.each = eachRegistrar(it.only)` so each generated row registers as a focused test, honoring `.only` exclusivity instead of merely avoiding the crash. Add tap-only-each.fixture.js, which asserts the semantics (ordinary siblings are dropped; only the two rows run) so a naive no-throw restore that registered non-exclusive rows would still fail it.
pmatos
deleted the
sym/jsse/293-node-test-harness-honor-mocha-only-exclusivity-in-describe-only-it-only
branch
July 20, 2026 06:28
Contributor
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #293