Skip to content

feat: ferro tunnel - #831

Open
zreigz wants to merge 7 commits into
mainfrom
lukasz/prod-5236-ferrotunnel-base-reverse-tunnel-for-plural-cloudnetwork
Open

zreigz wants to merge 7 commits into
mainfrom
lukasz/prod-5236-ferrotunnel-base-reverse-tunnel-for-plural-cloudnetwork

Conversation

@zreigz

@zreigz zreigz commented Sep 24, 2026

Copy link
Copy Markdown
Member

Test Plan

Checklist

  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added tests to cover my changes.
  • If required, I have updated the Plural documentation accordingly.

@zreigz
zreigz requested a review from a team as a code owner September 24, 2026 13:01
@linear

linear Bot commented Sep 24, 2026

Copy link
Copy Markdown

PROD-5236

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 0/5

The PR is not safe to merge until the tunnel workload's image, credential, and service-account integration failures are addressed.

Findings

  1. P1 Tunnel ignores registry override ▶
  2. P1 Configured token key is ignored ▶
  3. P1 Default leaves TLS credentials unused ▶
  4. P1 Deployment can lack token Secret ▶
  5. P1 Security Tunnel inherits cluster-admin access ▶
  6. P2 Observability selects tunnel pods ▶
  7. P2 Credential changes lack rollout signal ▶

Summary

The PR adds an optional FerroTunnel client Deployment, a chart-managed credential Secret, Helm defaults, and Liquid mappings for managed installations.

  • The new workload has image-registry, credential-mount, and service-account integration issues.
  • Its labels also broaden observability Service selection, and credential updates lack a rollout signal.

Reviews (1) · Last reviewed commit: "ferro tunnel"

Comment thread charts/deployment-operator/templates/tunnel-controller.yaml Outdated
Comment thread charts/deployment-operator/templates/tunnel-controller.yaml Outdated
Comment thread charts/deployment-operator/templates/tunnel-secret.yaml Outdated
Comment thread charts/deployment-operator/values.yaml Outdated
Comment thread charts/deployment-operator/templates/tunnel-controller.yaml Outdated
Comment thread charts/deployment-operator/templates/tunnel-controller.yaml Outdated
Comment thread charts/deployment-operator/templates/tunnel-controller.yaml Outdated
@zreigz zreigz changed the title ferro tunnel feat: ferro tunnel Sep 24, 2026
@michaeljguarino

Copy link
Copy Markdown
Member

the idea here is this tunnel controller is created via crd and not via helm here

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants