Skip to content

perf: optimize ColorValidator — up to 3x faster on arrays, 14x on scalars #5576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KRRT7 wants to merge 7 commits into
base: main
Choose a base branch
from
+278 −172
Open

perf: optimize ColorValidator — up to 3x faster on arrays, 14x on scalars #5576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
512575d
perf(validators): optimize ColorValidator with 3x speedup on arrays
KRRT7 Apr 16, 2026
8fc2a9c
fix(validators): fix silent invalid color acceptance in 2D numpy arrays
KRRT7 Apr 16, 2026
16a151f
Merge remote-tracking branch 'upstream/main' into perf/color-validato…
KRRT7 Apr 16, 2026
237044e
chore: ruff format and CHANGELOG entry
KRRT7 Apr 16, 2026
cab1e4d
perf(utils): optimize to_dict serialization path
KRRT7 Apr 16, 2026
40561ca
chore: update CHANGELOG with to_dict optimization
KRRT7 Apr 16, 2026
8734a7e
revert: remove to_dict optimization (moved to separate PR)
KRRT7 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased

### Fixed
- Fix `ColorValidator` silently accepting invalid colors in 2D numpy arrays instead of raising `ValueError` [[#5576](https://github.com/plotly/plotly.py/pull/5576)]
- Fix issue where user-specified `color_continuous_scale` was ignored when template had `autocolorscale=True` [[#5439](https://github.com/plotly/plotly.py/pull/5439)], with thanks to @antonymilne for the contribution!
- Update tests to be compatible with numpy 2.4 [[#5522](https://github.com/plotly/plotly.py/pull/5522)], with thanks to @thunze for the contribution!

### Performance
- Optimize `ColorValidator` array validation: up to 3x faster on numpy arrays, 2x on lists, 14x on scalars [[#5576](https://github.com/plotly/plotly.py/pull/5576)]

### Updated
- The `__eq__` method for `graph_objects` classes now returns `NotImplemented` to give the other operand an opportunity to handle the comparison [[#5547](https://github.com/plotly/plotly.py/pull/5547)], with thanks to @RazerM for the contribution!

Expand Down
Loading