fix(funnel/waterfall): respect textinfo token order

[Abineshabee]

What this fixes

Fixes #7751

go.Funnel with textinfo="percent initial+value" was displaying
value before percent (e.g. "700 70.0%") regardless of the order
specified by the user.

Root cause

In src/traces/bar/plot.js, the calcTextinfo function pushed
funnel tokens (value, percent initial/previous/total) and
waterfall tokens (initial, delta, final) in a hardcoded
sequence, ignoring the order of tokens in the textinfo string.

Fix

Replaced hardcoded hasFlag() checks with a loop over parts[]
(the user-specified token order) for both funnel and waterfall traces.

Before

"percent initial+value" → "1000 100.0%" ❌

After

"percent initial+value" → "100.0% 1000" ✅

Notes

• Backward compatible — existing behavior unchanged when token
  order was already correct
• label and text tokens still use fixed ordering and are
  not modified in this PR
• Fix applies to both funnel and waterfall traces as requested

[emilykl]

Hi @Abineshabee ! Thanks for the PR. This looks like it's on the right track; I'll take a review pass through the code. Let us know if you would like assistance with the failing test.

Could you please update the PR description to include screenshots or a codepen demonstrating the fix?

[emilykl]

Left a few comments, I'll take another look once you're ready @Abineshabee !

[Abineshabee]

@emilykl I've addressed both points:

1. Switched to for (var part in parts) loop syntax
2. Included label and text flags inside the ordered loop
   so all tokens now respect user-specified order consistently.
   Also normalized parts with .map(p => p.trim()) to handle
   any whitespace edge cases. Ready for another look!

[emilykl]

Thanks @Abineshabee for the quick turnaround! Before I take another look, can you update the PR description to add screenshots of the fix in action, and also fix the failing test? I'm happy to assist with either, just let me know.

[Abineshabee]

@emilykl Updated the test with proper safety checks. Ready for another look!

[Abineshabee]

@emilykl The only remaining CI failure is isosurface_test.js @gl should display hover labels
which is a pre-existing flaky GL test unrelated to this PR.
It fails inconsistently across runs (different hover values each time)
and is not caused by my changes to src/traces/bar/plot.js.

All funnel and waterfall tests pass. Ready for review !

[emilykl]

Great! Taking another look.

[emilykl]

@Abineshabee This looks great! See my comments for additional small changes.

The new logic in calcTextInfo() I think is much easier to understand than the old logic, so that's a nice bonus to this fix.

---

There's one more chunk of work needed on this PR: Updating other trace types to respect token order in textinfo, so that textinfo works the same way for all traces.

Luckily there's only two other functions which need to be updated:

• formatSliceLabel() in src/traces/pie/plot.js
• formatSliceLabel() in src/traces/sunburst/plot.js

Both of those functions should be refactored similarly to calcTextInfo(), so that they also respect token order. Let me know if you run into any issues with that step, I'm happy to assist. Make sure to add a Jasmine test for sunburst and pie as well.

Thanks for working on this fix!

[emilykl]

Also: You're correct that the one failing test is unrelated to these changes. That test is sometimes flaky. If it's still failing after your next commits I'll look into it.

[Abineshabee]

Hi @emilykl — thanks for the detailed review and for guiding this fix in the right direction!

Here's a summary of everything updated in this latest push:

src/traces/bar/plot.js

• Removed .trim() — validation already happens at coerce step
• Removed hasFlag() — replaced with for(var part in parts) loop using part === '...' checks
• Moved waterfall calculations (initial, delta, final) inline inside the loop
• label and text tokens moved inside the loop so all tokens respect user-specified order consistently

src/traces/pie/plot.js

• Refactored formatSliceLabel() — replaced hasFlag() checks with for(var part in parts) loop
• All tokens (label, text, value, percent) now respect user-specified order

src/traces/sunburst/plot.js

• Refactored formatSliceLabel() — replaced hasFlag() checks with for(var part in parts) loop
• All tokens (label, value, text, current path, percent parent, percent entry, percent root) now respect user-specified order
• Percent pre-count loop retained for hasMultiplePercents label logic

test/jasmine/tests/funnel_test.js

• Replaced indirect positional assertions with exact textContent checks as suggested
• Uses existing gd from beforeEach, follows done/done.fail pattern consistent with the rest of the suite

test/jasmine/tests/pie_test.js

• Added test asserting percent+label renders in user-specified order

test/jasmine/tests/sunburst_test.js

• Added test asserting value+label renders in user-specified order

All funnel, waterfall, pie and sunburst tests pass. The one remaining CI failure (isosurface_test.js) is the pre-existing flaky GL test unrelated to these changes.

Ready for another look!

[emilykl]

Thanks @Abineshabee for the quick turnaround! I'll take another look.

[Abineshabee]

Thank for your review and suggestions , now I am working on updates

[emilykl]

@Abineshabee I've finished my review pass! Just a few remaining items:

• Some small tweaks to code (see comments)

• Make sure to use the same for loop style in all 3 files where you have added one. I like the version below (for var i in parts) which you had used previously, but I don't care too much as long as it's consistent and doesn't reuse variable names.

for(var i in parts) {
        var part = parts[i];

• There is a failing Jasmine test (should be able to restyle *textinfo*) which I think is expected due to this change. The test will need to be updated to expect the values in the new order.

• There are some failing image tests in the test-baselines CI job which I believe are expected as well based on these changes. You will need to download the updated images from the CircleCI "Artifacts" tab (under test_images) and commit them to the repo in the test/image/baselines/ folder. Double-check that the changes are expected.