Support processUnpinnedColumns#470
Conversation
| # TODO: is there a pinned right? | ||
| self.wait_for_pinned_column_count(expected, pin_state="left") | ||
|
|
||
| def _header_class_for_pin_state(self, pin_state: Literal["left", "right", "scrolling"]): |
There was a problem hiding this comment.
The header classes will change with AgGrid 36 (.ag-grid-pinned-left-cells .ag-grid-scrolling-cells .ag-grid-pinned-right-cells) so I thought it would be good to already locate this in one method.
|
|
||
| def wait_for_pinned_cols(self, expected): | ||
| # TODO: is there a pinned right? | ||
| self.wait_for_pinned_column_count(expected, pin_state="left") |
There was a problem hiding this comment.
I frowned upon refactoring all calls to wait_for_pinned_column_count, so kept this in place and removed the TODO, because the other methods now would support left/right/scrolling.
|
|
||
| grid = utils.Grid(dash_duo, "grid") | ||
|
|
||
| grid.wait_for_pinned_column(col_id="COL_0", pin_state="left") |
There was a problem hiding this comment.
This would fail without unpinAllButFirstColumn, because default AgGrid behaviour would be to start unpinning at COL_0.
|
Thanks so much for the PR and the updated tests 🎉 I'm going to switch this to the v35 branch, which should fix the unrelated tests that are failing. |
|
Perfect.
We're on 33, but we're not blocked by this, because we workaround using a clientside callback to set the parameter. Hence, any release would just be super fine for us. |
2 participants
This would close #468
It basically just adds processUnpinnedColumns to src/lib/utils/propCategories.js and adds a test for this.
Please feel free to make changes.