fix: make schema consumers tolerant of nullable containers - #2221
Draft
kpal81xd wants to merge 10 commits into
Draft
fix: make schema consumers tolerant of nullable containers#2221kpal81xd wants to merge 10 commits into
kpal81xd wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Extract the comparison into a pure, testable module (matching the toolbar-order pattern); deep-equal.ts keeps the editor.method wiring. The missingFlagForField null-guard decision (Step 5) is deferred to the integrated template-instance e2e, since a spurious override can only manifest once the explicit-null catalog is deployed.
…resence Custom-AABB toggle now reads aabbCenter as a value and writes the explicit null off-state on both the change and undo handlers, so turning it off never deletes the required key. UV1 and imported-material checks read their explicit values.
kpal81xd
force-pushed
the
fix/schema-consumer-nullability
branch
from
August 26, 2026 09:05
881ec19 to
5c605bf
Compare
kpal81xd
force-pushed
the
fix/schema-consumer-nullability
branch
from
August 26, 2026 09:09
5c605bf to
fb95d52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the editor's schema API tolerant of catalogs where object containers and reference fields are nullable (
anyOf: [{…}, {type: 'null'}]) and carry explicit defaults, instead of being implicitly absent. All changes are backward-compatible with today's catalog.getFields/getAssetTypesresolve through a nullability wrapper.nullas equal to an absent key.unsetdeletes on dynamic paths and resets fixed fields to their default.staticlightmap duplicate.Smoke test