Document shadow and picker pass support for ShaderMaterial - #1110
Open
mvaligursky wants to merge 2 commits into
Open
Document shadow and picker pass support for ShaderMaterial#1110mvaligursky wants to merge 2 commits into
mvaligursky wants to merge 2 commits into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge until engine 2.22 is released — the
shadowCasterPSchunk documented here ships with that release (playcanvas/engine#9116).Adds two subsections to the Shader Includes section of the Shaders page (EN + JA):
Changes:
ShaderMaterialfragment shader casts shadows using#include "shadowCasterPS"andgetShadowOutput(), including the supported shadow types (all types for directional lights, PCF for spot lights, no omni), and the recommendation to skip forward-only work with#ifndef SHADOW_PASS.ShaderMaterialfragment shader supports thePickerusing#include "pickPS"andgetPickOutput(). This feature is already available in released engine versions, but was previously undocumented.