Skip to content

chore: require Node 22, test on 22 and 24 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gorandodig merged 2 commits into from
Aug 28, 2026
Merged

chore: require Node 22, test on 22 and 24 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b2ea4a
chore: require Node 22, test on 22 and 24
gorandodig Aug 24, 2026
0a5e52b
Run the pre-publish tests on the same Node as the publish
gorandodig Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22]
node: [22, 24]

steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
ref: ${{ github.event.release.tag_name || github.sha }}
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 20
node-version: 24
cache: npm
- run: npm ci
- run: npm test
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:

- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22 # trusted publishing needs >= 22.14
node-version: 24 # LTS; npm trusted publishing needs >= 22.14
cache: npm

- name: Use an npm that supports trusted publishing
Expand Down
2 changes: 1 addition & 1 deletion RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ at the repo root — gitignored, and the only place a webhook should live locall
| Trusted publisher | npmjs.com → `plain-forge` → Settings → Trusted Publisher | GitHub Actions, `plainlang/plain-forge`, workflow `publish.yml` |
| `SLACK_WEBHOOK_URL` | repo secret | notifications are skipped without it |
| `LINEAR_ACCESS_KEY` | repo secret | records the release in Linear; the job is currently commented out in `publish.yml` |
| Branch protection | `main` | `Test (node 18 / 20 / 22)` required, no force pushes, no deletion |
| Branch protection | `main` | `Test (node 22 / 24)` required, no force pushes, no deletion |

**The workflow filename is part of the trust contract.** Renaming `publish.yml` breaks
publishing until the trusted publisher entry on npmjs.com is updated to match.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Conversational spec-writing tool for ***plain specification language",
"type": "module",
"engines": {
"node": ">=18"
"node": ">=22"
},
"repository": {
"type": "git",
Expand Down