ci: record releases in Linear, pin and update workflow actions - #18
Merged
Conversation
zanjonke
reviewed
Aug 25, 2026
zanjonke
left a comment
zanjonke
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good. Left 2 minor comments. I can also the LINEAR_ACCESS_KEY into the repo secrets once we merge this.
Comment on lines
+127
to
+134
| # Non-fatal: the package is already on npm. | ||
| - name: Record release in Linear | ||
| continue-on-error: true | ||
| uses: linear/linear-release-action@0a25abab892a91062ebf42260dbb2ce6277aa205 # v0.16.0 | ||
| with: | ||
| access_key: ${{ secrets.LINEAR_ACCESS_KEY }} | ||
| version: ${{ github.event.release.tag_name }} | ||
|
|
Collaborator
There was a problem hiding this comment.
I think it would be better if this is a dedicated job rather than a step with publish. The publishjob has OIDC access that linear doesnt need. Less risk of things going out of hand.
Member
Author
There was a problem hiding this comment.
Agreed, done in e7e5697. It runs with contents: read and no OIDC.
Comment on lines
+27
to
+28
| - uses: actions/checkout@v7 | ||
| - uses: actions/setup-node@v7 |
Collaborator
There was a problem hiding this comment.
For consistency sake it would be better that we use the same pinned SHA as in the publish.yml.
Member
Author
|
Both addressed. I've already added the LINEAR_ACCESS_KEY secret for the pipeline, thanks! |
sync runs in the publish job after npm publish and before the Slack notification. Non-fatal: the package is already published, so a failure there cannot turn a green publish red. The release is identified by the tag. The publish checkout was shallow; the scan range needs full history. publish.yml is SHA-pinned; it holds id-token: write for trusted publishing. ci.yml stays on tags. Bumped checkout v7 and setup-node v7. Dependabot added for github-actions so the SHA pins stay patched.
The publish job holds id-token: write for trusted publishing. Recording a release needs none of it, so it runs in a job with contents: read. The publish job's checkout drops fetch-depth: 0 with it — that was there only for the release scan, which now happens elsewhere. A failure was also invisible: the step is non-fatal by design, so the job stayed green and nothing was logged. It now posts to Slack on the step's own outcome, since failure() never fires when continue-on-error swallows the error. The CLI the action downloads is pinned too, not just the action.
CI and the publish path were running different versions of the same actions, so a bad release would surface in a publish rather than in a pull request.
Commented out rather than removed, so re-enabling is a straight uncomment.
gorandodig
force-pushed
the
ci/linear-releases
branch
from
August 28, 2026 15:32
772d5fc to
c8cbbcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records each npm release in Linear.
syncruns in the publish job afternpm publish. The release is identified by the tag.publish.ymlis SHA-pinned.github/dependabot.ymlforgithub-actions, so the SHA pins stay patched.fetch-depth: 0so scan range<previous release>..HEADis possible