Report a malformed SSO config instead of panicking

[omlahore]

What happens

SharedSSOConfig.UnmarshalJSON decodes the control-plane config into map[string]interface{} and then asserts on two lookups out of it without the comma-ok, so a malformed config panics during load instead of being reported.

pkg/config/control_plane.go:

provider := m["provider"].(string)
...
name, ok := m["name"]
if !ok {
    return fmt.Errorf("name field in SharedSSOConfig is required")
}
s.Name = name.(string)

The name case is the clearer omission: the code already checks that the key is present, then asserts its type unchecked.

Reproduction

--- FAIL: TestSharedSSOConfigMalformed/provider_missing
    panicked on user config: interface conversion: interface {} is nil, not string
--- FAIL: TestSharedSSOConfigMalformed/provider_a_number
    panicked on user config: interface conversion: interface {} is float64, not string
--- FAIL: TestSharedSSOConfigMalformed/name_a_number
    panicked on user config: interface conversion: interface {} is float64, not string

The change

Both lookups use the checked form and return an error naming the field and the type that was there. The same fix is applied to pkg/configv1/control_plane.go, which carries an identical copy.

go test ./pkg/config/ ./pkg/configv1/ is green.

Separate from #7326, which fixes the same class in pipectl migrate.

[netlify]

✅ Deploy Preview for pipecd-site canceled.

Name	Link
🔨 Latest commit	9177ce0
🔍 Latest deploy log	https://app.netlify.com/projects/pipecd-site/deploys/6a9e72e295f7f20009cb3cfa

[Copilot]

🟡 Changes recommended

The new test file is missing the required license header and the malformed-config test currently ignores the unmarshal error (and there’s no equivalent regression coverage for the configv1 copy).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR hardens control-plane Shared SSO config JSON unmarshalling so malformed user config is reported as a validation error instead of triggering a panic during config load.

Changes:

• Replace unchecked type assertions for provider and name with comma-ok assertions and return descriptive errors on mismatch (in both pkg/config and pkg/configv1).
• Add a regression test ensuring malformed SharedSSO configs do not panic during json.Unmarshal.

File summaries

File	Description
pkg/config/control_plane.go	Makes SharedSSOConfig.UnmarshalJSON robust to missing/wrong-typed provider and name fields by returning errors instead of panicking.
pkg/configv1/control_plane.go	Mirrors the same safer unmarshalling logic in the v1 config package.
pkg/config/shared_sso_config_test.go	Adds a regression test intended to cover malformed SharedSSO configs during JSON unmarshalling.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.