Skip to content

Page datastore queries that fetched all applications #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinivasr wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Page datastore queries that fetched all applications #7234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a20baf
page application and event store calls instead of fetching everything
srinivasr Aug 24, 2026
21be04a
fix indexes — Disabled field was missing from application queries
srinivasr Aug 26, 2026
201421d
fix: bump pagination page sizes to 1000
srinivasr Aug 26, 2026
b913526
Merge branch 'master' into fix/list-applications-pagination
srinivasr Aug 28, 2026
ee44d84
Merge branch 'master' into fix/list-applications-pagination
srinivasr Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 177 additions & 0 deletions pkg/app/ops/firestoreindexensurer/indexes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,113 @@
[
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "PipedId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Disabled",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Disabled",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Name",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Disabled",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Kind",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Disabled",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Name",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Kind",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
Expand Down Expand Up @@ -141,6 +250,27 @@
}
]
},
{
"collectionGroup": "Application",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Disabled",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Command",
"queryScope": "COLLECTION",
Expand Down Expand Up @@ -550,6 +680,53 @@
}
]
},
{
"collectionGroup": "Event",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "CreatedAt",
"order": "DESCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "Event",
"queryScope": "COLLECTION",
"fields": [
{
"fieldPath": "ProjectId",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Status",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "CreatedAt",
"order": "ASCENDING",
"arrayConfig": ""
},
{
"fieldPath": "Id",
"order": "ASCENDING",
"arrayConfig": ""
}
]
},
{
"collectionGroup": "DeploymentChain",
"queryScope": "COLLECTION",
Expand Down
179 changes: 178 additions & 1 deletion pkg/app/ops/firestoreindexensurer/indexes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024 The PipeCD Authors.
// Copyright 2026 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -23,6 +23,115 @@ import (

func TestParseIndexes(t *testing.T) {
want := []index{
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "PipedId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Disabled",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Disabled",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Name",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Disabled",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Kind",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Disabled",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Name",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Kind",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Expand Down Expand Up @@ -165,6 +274,27 @@ func TestParseIndexes(t *testing.T) {
},
},
},
{
CollectionGroup: "Application",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Disabled",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Command",
QueryScope: "COLLECTION",
Expand Down Expand Up @@ -574,6 +704,53 @@ func TestParseIndexes(t *testing.T) {
},
},
},
{
CollectionGroup: "Event",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "CreatedAt",
Order: "DESCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "Event",
QueryScope: "COLLECTION",
Fields: []field{
{
FieldPath: "ProjectId",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Status",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "CreatedAt",
Order: "ASCENDING",
ArrayConfig: "",
},
{
FieldPath: "Id",
Order: "ASCENDING",
ArrayConfig: "",
},
},
},
{
CollectionGroup: "DeploymentChain",
QueryScope: "COLLECTION",
Expand Down
Loading