feat: imrpove perf by Codex - #16
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved API compatibility, provider export, and debug configuration issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (4)
What changed in this PR
Improves Volar/gtsc type-checking performance by adding type-checking-only generation and centralizing runtime typing helpers.
Changes:
- Adds
typeCheckingOnlysupport across the transpiler and language-plugin pipeline. - Optimizes generated typing and source-map replacements.
- Updates runtime exports, documentation, and VS Code launch configuration.
| File | Summary |
|---|---|
packages/tsc/src/index.ts |
Enables type-checking-only generation. |
packages/transpiler/src/transform/volar/walker.ts |
Adds typing-only state and runtime utility imports; provider compatibility issue (moderate, 3 votes) and comment nit (2 votes). |
packages/transpiler/src/transform/volar/replacements.ts |
Refactors generated type checks and offset mappings. |
packages/transpiler/src/transform/volar/index.ts |
Adds the Volar option; public API compatibility issue (moderate, 3 votes). |
packages/transpiler/src/index.ts |
Updates the public Volar API; existing callers may no longer type-check (moderate, 1 vote). |
packages/runtime/src/typing.ts |
Adds shared typing utilities. |
packages/runtime/src/index.ts |
Exports typing utilities. |
packages/language-plugin/src/virtual_code.ts |
Uses the updated Volar configuration type. |
packages/language-plugin/src/language_plugin.ts |
Propagates type-checking-only configuration. |
docs/content/docs/internal/language-tooling.md |
Documents type-checking-only generation. |
.vscode/launch.json |
Changes the debug target to an external sibling checkout (moderate, 4 votes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceRoot}/packages/vscode", | ||
| "--folder-uri=${workspaceRoot}/examples/local" | ||
| "--folder-uri=${workspaceRoot}/../genius-invokation" |
Comment on lines
+20
to
+22
| export interface VolarTranspileOption extends TranspileOption { | ||
| /** Omit editor-only expressions, retaining all type validation. */ | ||
| typeCheckingOnly: boolean; |
Comment on lines
+385
to
+389
| { | ||
| type: "ImportSpecifier", | ||
| imported: { type: "Identifier", name: "TypingUtils" }, | ||
| local: state.utilNsId, | ||
| }, |
| whiteSpaceEnd: number, | ||
| ) => { | ||
| if (state.typeCheckingOnly) { | ||
| // type-checking do not need insert hint statement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.