Skip to content

fix(android): link pills around inline code are no longer squished - #8

Open
RVZO6 wants to merge 1 commit into
pingdotgg:feat/t3chat-markdown-parity-v2from
RVZO6:fix/android-pill-code-scale
Open

RVZO6 wants to merge 1 commit into
pingdotgg:feat/t3chat-markdown-parity-v2from
RVZO6:fix/android-pill-code-scale

Conversation

@RVZO6

@RVZO6 RVZO6 commented Oct 20, 2026 •

Copy link
Copy Markdown

On Android, a link pill whose text is inline code (for example a file link written as [`menu.js`](menu.js)) draws its label at about half width.

373f4ee pads inline code with a no-break space at each end, narrowed by CodePaddingSpan (ScaleXSpan(0.55f)). LinkPillSpan measures and draws with the paint of the link's first run, which is now that padding space. applyLabelStyle copies the paint with set(source) and never resets textScaleX. The label is measured and drawn at 0.55× width, so it fits without an ellipsis and just looks condensed.

applyLabelStyle now resets textScaleX = 1f. It sets up the paint for both measuring and drawing, so the pill's width and its label are both fixed. iOS doesn't use ScaleX padding and isn't affected.

Reported on a T3 Code Android nightly (v0.1.1-nightly.20261020.3386), the first build to ship this tarball.

🤖 Generated with Claude Code (Claude Opus 5.5)

Note

Fix squished link pills around inline code on Android

Sets the paint's horizontal text scale to 1.0 in LinkPillSpan after applying the link pill font size. This stops a preceding inline-code padding span from distorting the scale of link pill text. Change is in LinkPillSpan.kt.

Macroscope summarized 118a953.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8eb15e09-f6f6-4253-b78b-e9a96f544e3a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

RVZO6 added a commit to RVZO6/t3code that referenced this pull request Oct 21, 2026
Picks up pingdotgg/enriched-markdown#8, which resets the pill label's
horizontal text scale so it no longer inherits inline code's narrowed
padding space.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RVZO6
RVZO6 force-pushed the fix/android-pill-code-scale branch from 675136e to 118a953 Compare October 25, 2026 02:56
RVZO6 added a commit to RVZO6/t3code that referenced this pull request Oct 25, 2026
Picks up pingdotgg/enriched-markdown#8, which resets the pill label's
horizontal text scale so it no longer inherits inline code's narrowed
padding space.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant