test-nicole'sagen-commit#23191
Conversation
|
Hi @nicole-yc. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request cleans up and generalizes region-specific information across the 2022, 2023, and 2024 release notes for TiDB Cloud, removing specific references to regions like Mumbai, Osaka, and N. Virginia. The review feedback focuses on improving clarity, conciseness, and style guide compliance, specifically by recommending active voice, simplifying phrasing to 'Available in', and clarifying 'dual-region backup'.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - Support directly migrating data from Amazon Aurora MySQL, Amazon Relational Database Service (RDS) MySQL, or self-hosted MySQL-compatible databases to TiDB Cloud online. This feature is now in General Availability. | ||
|
|
||
| - Provide services in the following 6 regions: | ||
| - Provide services in the following 5 regions: |
There was a problem hiding this comment.
To make the sentence more concise and natural, you can simplify "Provide services in" to "Available in". This aligns with the style guide's principle of avoiding unnecessary words.
| - Provide services in the following 5 regions: | |
| - Available in the following 5 regions: |
References
- Avoid unnecessary words and repetition. (link)
| To use the PITR feature, make sure that your TiDB cluster version is at least v6.3.0 and the TiKV node size is at least 8 vCPU and 16 GiB. | ||
|
|
||
| By default, backup data is stored in the same region where the cluster is created. In Japan, for TiDB clusters hosted on GCP with PITR enabled, you can choose to store backup data in one or two regions (Tokyo and/or Osaka). Restoring data from an alternative region provides a higher level of data safety and can tolerate region failures. | ||
| By default, backup data is stored in the same region where the cluster is created. For TiDB clusters hosted on GCP with PITR enabled, you can choose to store backup data in a supported region. Restoring data from an alternative region provides a higher level of data safety and can tolerate region failures. |
There was a problem hiding this comment.
The phrases "is stored" and "is created" are in the passive voice. According to the style guide, we should avoid passive voice and write in the second person ("you") and present tense. Rewriting this to active voice makes the instruction more direct and clear.
| By default, backup data is stored in the same region where the cluster is created. For TiDB clusters hosted on GCP with PITR enabled, you can choose to store backup data in a supported region. Restoring data from an alternative region provides a higher level of data safety and can tolerate region failures. | |
| By default, TiDB Cloud stores backup data in the same region where you create the cluster. For TiDB clusters hosted on GCP with PITR enabled, you can choose to store backup data in a supported region. Restoring data from an alternative region provides a higher level of data safety and can tolerate region failures. |
References
- Avoid passive voice overuse (e.g., "The cluster is started by TiUP" -> "TiUP starts the cluster"). (link)
| - [TiDB Cloud Dedicated](/tidb-cloud/select-cluster-tier.md#tidb-cloud-dedicated) supports dual region backup (beta) on Google Cloud. | ||
|
|
||
| TiDB Cloud Dedicated clusters hosted on Google Cloud work seamlessly with Google Cloud Storage. Similar to the [Dual-regions](https://cloud.google.com/storage/docs/locations#location-dr) feature of Google Cloud Storage, the pair of regions that you use for the dual-region in TiDB Cloud Dedicated must be within the same multi-region. For example, Tokyo and Osaka are in the same multi-region `ASIA` so they can be used together for dual-region storage. | ||
| TiDB Cloud Dedicated clusters hosted on Google Cloud work seamlessly with Google Cloud Storage. Similar to the [Dual-regions](https://cloud.google.com/storage/docs/locations#location-dr) feature of Google Cloud Storage, the pair of regions that you use for the dual-region in TiDB Cloud Dedicated must be within the same multi-region. |
There was a problem hiding this comment.
The phrase "the dual-region" is slightly unclear and grammatically incomplete in this context. Specifying "dual-region backup" improves clarity and consistency with the feature name mentioned in the heading.
| TiDB Cloud Dedicated clusters hosted on Google Cloud work seamlessly with Google Cloud Storage. Similar to the [Dual-regions](https://cloud.google.com/storage/docs/locations#location-dr) feature of Google Cloud Storage, the pair of regions that you use for the dual-region in TiDB Cloud Dedicated must be within the same multi-region. | |
| TiDB Cloud Dedicated clusters hosted on Google Cloud work seamlessly with Google Cloud Storage. Similar to the [Dual-regions](https://cloud.google.com/storage/docs/locations#location-dr) feature of Google Cloud Storage, the pair of regions that you use for dual-region backup in TiDB Cloud Dedicated must be within the same multi-region. |
References
- Clarity, simplicity, completeness, and readability. (link)
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?