Fix deferred close-all and frozen reversal lifecycle#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_allcleanup by binding it to a fresh pending-order incarnation and the actual flattening orderRoot cause
The corpus fixture's scalar count gap hid two independent bug sets: six TradingView-only STOP carries were deleted by
close_allcleanup, while seven engine-only priced reversals crossed position cycles. On the accepted cumulative stack, A0B0 is 6 missing + 7 extra, A1B0 is 0 + 7, A0B1 is 6 + 0, and A1B1 is exact 2356/2356.Upstream
mainintentionally still reports one unrelated engine-only trade because accepted predecessor7638461has not landed upstream; this PR does not fold that separate change into scope.Validation