Corys contributions - #1
Open
cwaddingham wants to merge 2 commits into
Open
Conversation
added 2 commits
July 12, 2024 11:02
…mand to download the necessary dataset from Kaggle.
…vamped how credentials for Pinecone and Neo4j are handled.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dataset being used was not locally available and had to be downloaded separately from the notebook. Also, the auth credentials for both Pinecone and Neo4j were using locally scoped environment variables, but there was no
.envskeleton file to store them. This could result in confusion on how to authenticate to those systems.Solution
Added
kagglePython module to make downloading the dataset(s) easier, and also cleaned up the auth for Pinecone and Neo4j.Type of Change
Test Plan
Loaded the notebook in Colab and ran through it manually, confirming it works.