fix(evm): Base Sepolia USDC EIP-712 domain name is "USDC", not "USD Coin" - #30
Merged
TeoSlayer merged 1 commit intoJul 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfy/Verify/USDCDomainhardcode domain name"USD Coin". Base Sepolia USDC (0x036CbD53842c5426634e7929541eC2318f3dCF7e) uses"USDC"→ wrong domain separator → every signature on 84532 failstransferWithAuthorizationand x402 facilitator verification. Mainnets (1/8453/137) are all"USD Coin", so the default chain set masks it.Proof: on-chain
DOMAIN_SEPARATOR()is0x71f17a3b2ff373b803d70a5a07c046c1a2bc8e89c09ef722fcb047abe94c9818(84532) /0x02fa7265e7c5d81118673727957699e4d68f74cd74b7db77da710fe8a2c7834f(8453); recomputing the domain hash matches only with"USDC"/"USD Coin"respectively. x402 agrees:go/mechanisms/evm/constants.go→eip155:84532Name: "USDC".Change:
usdcDomainName(chainID)(84532→"USDC", else"USD Coin"— unknown chains unchanged), used in the three call sites. New test pinsDomain.Separator()for all fourKnownChainIDs()to on-chain values.Longer term you probably want name/version plumbed from x402
extra.name/extra.versionthroughpayment.Contract; happy to follow up if you're open to the app-store schema change.Found while integrating a diarize.io app against Stripe's x402 facilitator on Base Sepolia.