publish: NewTimer+Stop instead of time.After in the fan-out hot path - #35
Merged
Conversation
publishWith spawns one goroutine per subscriber per event, and each used time.After(publishWriteTimeout). time.After allocates a timer the runtime pins for the FULL 5 seconds, even when the write completes in microseconds. At the 100 events/s publish limit with S subscribers, steady state is up to 100*S*5 = 500*S live timers plus matching timer-heap entries — 50,000 pinned timers at S=100 — purely as GC and timer-heap pressure. Now time.NewTimer with defer Stop(), releasing the timer as soon as the write returns. Same correction already applied in the daemon's withRegistryDeadline, where the rationale is documented in-line for exactly this reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishWithspawns one goroutine per subscriber per event, and each usedtime.After(publishWriteTimeout).time.Afterallocates a timer that the runtime pins for the full 5 seconds, even when the write completes in microseconds. At the 100 events/s publish limit with S subscribers, steady state is up to100 x S x 5 = 500*Slive timers plus the matching timer-heap entries — 50,000 pinned timers at S=100, purely as GC and timer-heap pressure.Now
time.NewTimerwithdefer Stop(), so the timer is released as soon as the write returns.This is the same correction already applied in the daemon (
withRegistryDeadline), where the rationale is documented in-line for exactly this reason.Build, vet and tests pass.
Found during a codebase-wide sweep for resource leaks.
🤖 Generated with Claude Code