Warn when --fake marks multiple migrations as run#1400
Open
AnayGarodia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1255
piccolo migrations forwards --fakemarks pending migrations as run without applying them. When several migrations are pending, running it with--fakesilently fakes all of them, which is an easy way to lose track of which schema changes were actually applied.As agreed in #1255, this adds a warning when
--fakewill mark more than one migration as run, printed right after the "Running N migrations" line and before they are faked. A single faked migration is unchanged.The regression test (
test_forwards_fake_multiple_warns) fakes themusicapp's migrations withfake=Trueand asserts the warning is printed; it fails onmasterand passes with this change. The rest of the forwards/backwards suite still passes.