Escape DSAR request fields in the staff HTML email (OY-07) - #22
Merged
Merged
Conversation
buildDsarEmailHtml interpolated user.id, username, email, requestType,
jurisdiction, and the user-controlled details/jurisdiction fields straight
into an HTML email sent to contact@oyme.site. A requester could inject
arbitrary markup (link/section spoofing, phishing) into mail that staff
read.
Add an escapeHtml helper (& first, then < > " ') and wrap every
interpolated value.
- worker/routes/dsar.ts: escapeHtml helper; every ${...} in
buildDsarEmailHtml wrapped, user.id coerced via String().
- tests/worker/dsar.test.ts: submit details/jurisdiction containing
<script> and <img onerror> payloads and assert the outgoing email html
contains the escaped forms and not the raw tags.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015EkRWLSbdRZqE9uCeuuQce
Co-authored-by: jackowayed <18899+jackowayed@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildDsarEmailHtml interpolated user.id, username, email, requestType, jurisdiction, and the user-controlled details/jurisdiction fields straight into an HTML email sent to contact@oyme.site. A requester could inject arbitrary markup (link/section spoofing, phishing) into mail that staff read.
Add an escapeHtml helper (& first, then < > " ') and wrap every interpolated value.
This finding was OY-07 in the ID scheme my audit session came up with :P
Claude-Session: https://claude.ai/code/session_015EkRWLSbdRZqE9uCeuuQce