Expand WEB.DE read-only integration and IMAP regression coverage - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEB.DE IMAP access is now enabled. The existing TLS/authentication check passes on rerun: https://github.com/phore/phore-mailclient/actions/runs/34531131329.
This expands the provider check to read-only INBOX selection, UID search, bounded MIME reads of the three newest messages, cursor pagination, per-action Seen suppression and unchanged persistent flags. A transport guard rejects writes; attachments remain lazy and logs contain only fixed check labels. Empty inboxes explicitly skip message-dependent checks. No personal mail data is uploaded as artifacts.
Normal CI runs the same probe against seeded disposable Dovecot, with additional attachment byte-limit and failed-APPEND flag tests. Unit coverage adds invalid limits, malformed/wrong-folder cursors, protocol-controlled flags and empty-provider handling. The existing cursor fixture is isolated from messages added by other tests.
The separate secret-backed workflow runs on relevant changes on main and this exact branch, or manual dispatch; it does not use pull_request_target. Concurrent mailbox deletions or flag changes can fail provider assertions.
Validation at
00758fd7944c46438ac30236fe9b2101453d3f11:No production-code or Webklex upstream changes were required.