rfc-impl: remove RUST_VERSION ARG and rust.version label since setup script is not executed - #19
Open
phi9t wants to merge 1 commit into
Open
Conversation
…script is not executed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC implementation: remove RUST_VERSION ARG and rust.version label since setup script is not executed
Currently
container/dev_container.dockerfiledeclaresARG RUST_VERSION=1.79.0at line 8 and uses it only inLABEL rust.version="${RUST_VERSION}"at line 269. A comment at line 125 states 'Rust will be installed by setup script for proper user configuration' but no COPY or RUN forsetup_user_environment.shexists in the file. The ARG and its LABEL are dead code. RemoveARG RUST_VERSION=1.79.0(line 8) andLABEL rust.version="${RUST_VERSION}"(line 269). Do not remove PYTHON_VERSION, GO_VERSION, or BAZEL_VERSION as those are functionally used. Acceptance criterion:grep 'RUST_VERSION' container/dev_container.dockerfilereturns empty output.