Repository navigation
Do not write settings when showing their values - #1558
Merged
jecisc merged 1 commit intoOct 30, 2026
Merged
Conversation
Boolean, number, text and drop list items wrote the value of their setting back while showing it, because their presenters announce the initial value as a change. Setters may have side effects: showing Appearance > Standard fonts set the font size, which reset all the fonts. Show the value in StSettingPresenterItem>>withoutUpdatingSettingDo: so that only the edits of the user update the setting.
jecisc
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean, number, text and drop list items wrote the value of their setting back while showing it, because their presenters announce the initial value as a change. Setters may have side effects: showing Appearance > Standard fonts set the font size, which reset all the fonts. Show the value in StSettingPresenterItem>>withoutUpdatingSettingDo: so that only the edits of the user update the setting.