Repository navigation
Transcript: Introduce API agnostic to internal line return - #1545
Conversation
Requires: pharo-project/pharo#20078 Introduce an API independant to line ending. The goal is to have only one place in Pharo where we chose the internal line ending. The user does not need to care if the transcript uses cr, lf, crlf...
jecisc
changed the title
Gabriel-Darbord
left a comment
Gabriel-Darbord
left a comment
There was a problem hiding this comment.
LGTM, I think it's good to start moving past cr which is really just historical baggage :)
| { #category : 'streaming' } | ||
| StThreadSafeTranscript >> cr [ | ||
| "Output a cr on the receiver" | ||
| "To deprecate in favor of #newLine" |
There was a problem hiding this comment.
I'm not sure this should be deprecated, if we want to use cr explicitly then that seems fine.
What would need deprecation are all the methods using cr when they really mean newLine as you've done elsewhere.
There was a problem hiding this comment.
I deprecated it because this is the transcript and not a stream. Do you often need to print explicitly a cr and not a lf/crlf in a transcript?
I think that without rewriting, people will keep the #cr and we will have one place in the system with still crs
But if you really think it might make sense to keep it, I can update the PR
There was a problem hiding this comment.
OK that makes sense to me, not much point keeping cr on the transcript.
Requires: pharo-project/pharo#20078
Introduce an API independant to line ending. The goal is to have only one place in Pharo where we chose the internal line ending. The user does not need to care if the transcript uses cr, lf, crlf...