Fixed inspections#19
Merged
Merged
Conversation
dionisiydk
reviewed
May 31, 2025
| Extension { #name : 'UndefinedObject' } | ||
|
|
||
| { #category : '*Ghost-NewToolsSupport' } | ||
| UndefinedObject >> ghostPrintString [ |
Collaborator
There was a problem hiding this comment.
Why this method is needed for nil?
Contributor
Author
There was a problem hiding this comment.
When debugging GHMetaMessages, it may happen that ghost is not set yet. But in order to print GHMetaMessages instance, it sends ghostPrintString to the contents of ghost variable. In that case, debugger goes into flames 🔥🔥(I mean you get another debugger with an error and the original inspection part of the debugger stops showing anything). Another way to prevent this could be a nil check for the printing in GHMetaMessages.
Collaborator
|
@JanBliznicenko many thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
(sorry for not noticing in the previous PR)