T1 introspection - #2
Merged
Merged
Conversation
Assisted by: Claude Code
Assisted by: Claude Code
Assisted by: Claude Code
Assisted by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Code Metrics Report🚫 Code coverage is 98.6%. the condition in the
Details | | master (d5683dd) | #2 (437c77b) | +/- |
|---------------------|------------------|--------------|-------|
- | Coverage | 98.6% | 98.6% | -0.1% |
| Files | 25 | 31 | +6 |
| Lines | 519 | 736 | +217 |
+ | Covered | 512 | 726 | +214 |
| Test Execution Time | 1s | 1s | 0s |Code coverage of files in pull request scope (97.9% → 98.2%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFR
Added
route:list, listing every route the application answers with its method and Action class. Reads the Action classes rather than a route table, since ADR has none. #1config:show, showing the resolved project configuration and marking each value as declared or inferred. #1container:list, listing the services registered in the project container with their class and whether they have been resolved. #1event:list, listing the listeners attached to the project events manager. #1list(aliasescommands,enumerate), listing the available commands. #1bootstrapkey tocrest.php, naming the project front controller so commands that need a running application can boot one:'bootstrap' => App\Front\AppFront::class. Requires aboot()returning a container. #1Crest\Console\Input::argumentString(),optionString()andoptionStringOrNull(), narrowing the common string case so commands do not each repeat a type guard.Changed
make:actionnow writes aparams()declaration for routes with attributes, so they arrive constrained and cast rather than as raw strings.make:actionnow rejects a static segment after a placeholder and suggests the supported spelling:/album/{id}/editis reported as/album/edit/{id}. Arguments trail the static path, so the first form has no class name that describes it.Crest\AdrtoCrest\ADR, andFlavor::Adr,Flavor::CliandFlavor::MvctoFlavor::ADR,Flavor::CLIandFlavor::MVC, matchingPhalcon\ADR. Backed values are unchanged.Crest\ADR\CandidateSourcetoActionResolverandPhalconRouterCandidatestoPhalconRouterResolver. One path now names exactly one Action, so there are no candidates to choose between.config.platform, so the lock matches the declared minimum.Removed
make:action. One path names exactly one Action, so nothing can be shadowed.