Skip to content

[NFR]: Code and metadata housekeeping #20

Description

@niden

Goal: small code and metadata fixes, found in a review on 2026-09-25.

src/Project/Config.php

  • Move the comment at line 165 ("crest.php never restates the autoload map..."). It is above the bootstrap block, but it describes the self::psr4Map($root) argument.
  • Put the methods in the house order: public, then protected, then private, each alphabetical. The private static methods defaultPaths(), fromArray(), infer() and psr4Map() are between discover() and the public instance methods.
  • Align 'action' => 'src/Action' (line 107) with the other keys.
  • The isDeclared() docblock lists namespaces, but fromArray() does not track it. Fix one of the two.

composer.json

  • Sort phalcon/code-quality into place in require-dev.
  • Fix the indentation of optimize-autoloader.

CHANGELOG.md

  • The talon entry says ^0.9. composer.json has ^1.0.0.
  • Add an entry for phalcon/code-quality.

Done when

  • All the items above are fixed, and composer cs, composer analyze and the tests pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

  • Status
    Implemented

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions