Adds errata for Rainbow - #200
Merged
Merged
Conversation
prabhatnagarajan
commented
Nov 28, 2025
prabhatnagarajan
commented
Contributor
- A hyperparameter (the target network update interval) is incorrect in the reproduction of Rainbow. This PR makes a note to clarify this issue.
Contributor
Author
|
@keisuke-nakata sorry, this needs |
Member
|
/test |
|
Successfully created a job for commit db1dec1: |
Member
|
I forgot how we set this value, but it seems you are right. The original paper (https://arxiv.org/abs/1710.02298) is very clear that it is 32K frames, not steps. For 
|
Contributor
Author
|
Feel free to merge (I can't). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.