Conversation
Signed-off-by: Ian Lewis <ianlewis@preferred.jp>
There was a problem hiding this comment.
Pull request overview
This PR adds ARM64 architecture support to the Docker build pipeline by including linux/arm64 as a target platform alongside the existing linux/amd64 platform.
Changes:
- Updated Docker build configurations to support multi-architecture builds (amd64 and arm64)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.publish.yml | Added arm64 platform to the release Docker build configuration |
| .github/workflows/pull_request.build.yml | Added arm64 platform to the pull request Docker build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| platforms: linux/amd64 | ||
| platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
Building for multiple platforms (amd64 and arm64) in PR builds will significantly increase CI build times. Consider only building arm64 in the release workflow to keep PR feedback fast, or make multi-platform builds optional for PRs.
| platforms: linux/amd64,linux/arm64 | |
| platforms: ${{ github.event_name == 'pull_request' && 'linux/arm64' || 'linux/amd64,linux/arm64' }} |
There was a problem hiding this comment.
No. I want to test that building for both architectures work on pull requests.
There was a problem hiding this comment.
Yeah, using qemu does take too long.. Perhaps we could build the reloader on separate architectures and then COPY into the image.
No description provided.