Add workflows to exexute tests in CI - #2
Merged
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
github-actions-ci-workflow
branch
from
August 25, 2026 09:29
91191cc to
9e81cbd
Compare
tenzen-y
marked this pull request as ready for review
August 25, 2026 09:42
tenzen-y
added a commit
that referenced
this pull request
Aug 26, 2026
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
added a commit
that referenced
this pull request
Aug 26, 2026
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
added a commit
that referenced
this pull request
Aug 26, 2026
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
added a commit
that referenced
this pull request
Aug 26, 2026
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
added a commit
that referenced
this pull request
Aug 26, 2026
* Drop kubernetes-sigs#1077 from this release exclusive placement") widened the Pod mutating webhook: Default() started running for every JobSet Pod and stamped the jobset.sigs.k8s.io/priority label on all of them. This release does not want that behavior change, so remove it: - Default() again returns early unless the parent JobSet uses the exclusive placement feature. - The priority label is set in patchPod(), so only Pods that actually go through exclusive placement are labeled. The unrelated fix that kubernetes-sigs#1077 also carried is kept on purpose: Node is a cluster-scoped resource, so no namespace is passed to client.Get when looking up the leader Pod's Node. Restoring the namespace would break TestDefault/follower_pod,_leader_scheduled with `nodes "node-a" not found`. The TestDefault case "jobset pod, no exclusive placement, with priority" is updated to match: such a Pod is no longer labeled. Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Add image publishing workflow (#1) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Add workflows to exexute tests in CI (#2) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * update kind to 0.32.0 (kubernetes-sigs#1260) --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Co-authored-by: Kevin Hannon <kehannon@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a workflow to execute the following tests in CI: