Optionally parse with JSON::PP - #36
Open
XanC wants to merge 5 commits into
Open
Conversation
Owner
|
Thanks for looking into this. It seems like a reasonable thing to want. I can't use this PR as-is because there are no tests and no updates to documentation to explain to the user how to use the new functionality. |
Author
|
Thanks. I've added a documentation line describing the new PP option. Also I created a new PP version of each test that called WebService::Solr->new(), modifying each one to enable the PP option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upgrading from Debian Wheezy to Debian Stretch, I found that my script that runs WebService::Solr no longer worked: JSON::XS in WebService::Solr::Response always failed to parse the response, even when the response was perfectly valid. I believe this is because my script is multi-threaded, and JSON::XS is not guaranteed thread-safe. JSON::PP works perfectly.
This pull request implements an option to allow WebService::Solr to use JSON::PP. There may be a better way of achieving this.
Thank you for WebService::Solr!