fix: allow --init without a tests directory - #1939
Open
tiagoabsantos wants to merge 1 commit into
Open
tiagoabsantos wants to merge 1 commit into
tiagoabsantos wants to merge 1 commit into
Conversation
Boot aborted before TIA state was registered, and shutdown then tried to construct the plugin. That hid the real error behind "State cannot be resolved" on a fresh install. Closes pestphp#1934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor/bin/pest --initon a project with notests/directory aborted inBootFilesbefore TIA registered itsStatebinding.A dependency with the name [Pest\Plugins\Tia\Contracts\State] cannot be resolvedinstead of creating the suite.--initnow skips that directory check, and plugin termination does not run when boot never finished.Closes #1934
Test plan
tests/Features/Init.phpon PHP 8.4:--initcreatesphpunit.xmland the example tests, and a missingtests/directory no longer fatals while resolving TIA statecomposer require pestphp/pest --dev --with-all-dependencies, thenvendor/bin/pest --init