DISTMYSQL-622: Let allowlist-set run unattended - #401
Open
nogueiraanderson wants to merge 1 commit into
Open
Conversation
- Drop the interactive overwrite confirm: read -p dies under set -e in any non-TTY caller, so the recipe could not run from automation - The previous value is still echoed before the write, PutParameter is CloudTrail-audited, and the terraform/allowlists.tf guards keep gating the apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
just allowlist-setoverwrites without the interactive confirm, so it runs from automation and non-TTY sessionsWhy
read -pprompt exits non-zero underset -ein any non-interactive caller, making the recipe unusable outside a terminalterraform/allowlists.tfguards (no0.0.0.0/0, at least one valid CIDR) keep gating the applyTickets