Conversation
|
|
OBS Build Check — ✅ Builds passedPackages for this PR are being built at isv:percona:PR:pr-4.
|
rjd15372
added a commit
that referenced
this pull request
Jul 29, 2026
The dep-cascade enriches the forward dep map with Dockerfile-image -> RPM
edges by fetching each image's per-package _buildinfo, but hardcoded the
repository name "images" -- the old containers layout, where each
:containers:<flavor> subproject exposes a single repo literally named
"images". The restructured single ":containers" subproject names its
image repos after the flavor (ubi8/ubi9), so the _buildinfo fetch 404ed
("has no repository 'images'"), _fetch_image_pkg_deps swallowed the error
and returned no edges, and container images were never dep-promoted when a
package they install was promoted.
Seen on percona/obs-packaging PR #4: sync push --branch-from promoted
ppg:staging:18/percona-pg_tde but created the PR project without any
:containers subproject, so no ppg:18 images were rebuilt.
Commit 9697450 ("sync: map <flavor>-images label to flavor-named container
repo") already handled the --only-repos label expansion for the new layout
but missed the image_pkgs construction sites.
Add image_dep_query_repos(), which derives the repo names to query from
the image's own project config (with inheritance) so both layouts work,
filtered by the effective --only-repos set when given, and use it at all
three call sites (sync branch path, sync plain-push path, build
dependency). The sync paths reuse the existing _target_repos_cache.
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.