Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Update Sogbot - #2518

Open
QuintenQVD0 wants to merge 1 commit into
masterfrom
SogBot
Open

QuintenQVD0 wants to merge 1 commit into
masterfrom
SogBot

Conversation

@QuintenQVD0

@QuintenQVD0 QuintenQVD0 commented Oct 21, 2023 •

Copy link
Copy Markdown
Collaborator

Description

Checklist for all submissions

  • move to our official git release grab script
  • modify the script if the release is not latest that the github api returns 50 results and not 25 if anyone is updating from a old version
  • display the nodejs version as docker image and not the whole image
    closes [Bug]: SogeBot ignoring VERSION variable #2499
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

@gOOvER

gOOvER commented Oct 21, 2023 •

Copy link
Copy Markdown
Contributor

there is No Support for older Versions, only for latest. thats why the Script should not contain versions

the used Version in #2499 was really old :) He didnt update for over 2 years :)

@QuintenQVD0

Copy link
Copy Markdown
Collaborator Author

there is No Support for older Versions, only for latest. thats why the Script should not contain versions

the used Version in #2499 was really old :) He didnt update for over 2 years :)

its limited to the latest 50 version so that is not that bad? if they have to upgrade it is posible, default is still latest

@gOOvER

gOOvER commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

in my eye's still not needed this change

@QuintenQVD0

Copy link
Copy Markdown
Collaborator Author

The bot itself does not support older version. But we have a version variable so i find then that it should work or ir should just be removed.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SogeBot ignoring VERSION variable

2 participants