Repository navigation
kern-serve: the history checkpoint waits for the slot being carved - #48
Merged
Merged
Conversation
A recurrent state can only be snapshotted at the moment the prefill stops at `history_tokens`, so a `Denied::Remapping` there was a lost snapshot: in the 2026-10-08 AgentX run 42 of 111 were, every one with a remap in flight. `Runtime::settle` lands the remap in flight and whatever the pool plans after it, blocking on the remap thread; the scheduler's `keep_prompt` calls it through `Tray::settle` and retries. This is the one place that waits: the prefill has just read its output back, so the streams the remap waits on are drained and the wait is the remap's own milliseconds. Gate (tray08 GB300, AgentX aiperf 180 s, c24, same trace and seed as B): 112 history checkpoints kept, 0 skipped (B: 69 / 42); remaps 44 -> 85; prefix hit 7.79M -> 8.00M tokens, aiperf cached 92.8% -> 94.1% (the attribution of B's skips predicted 94.0%); 84 requests, 245 tok/s, TTFT p50 157 ms, ITL p50 19 ms, the rest within B's noise. `~/bench_results/2026-10-08-kern-serve-agentx-3min`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: JinYan Su <751080330@qq.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recurrent state can only be snapshotted at the moment the prefill stops at
history_tokens, so aDenied::Remappingthere was a lost snapshot: in the 2026-10-08 AgentX run 42 of 111 were, every one with a remap in flight.Runtime::settlelands the remap in flight and whatever the pool plans after it, blocking on the remap thread;keep_promptcalls it throughTray::settleand retries. This is the one place that waits: the prefill has just read its output back, so the streams the remap waits on are drained and the wait is the remap's own milliseconds.Gate (tray08 GB300, AgentX aiperf 180 s, c24, same trace and seed as B):
~/bench_results/2026-10-08-kern-serve-agentx-3min(bin/kern-serve-c,results/c-180s/,scripts/attribute.py).🤖 Generated with Claude Code