Repository navigation
fix(infra): build the remote web image from the apps context - #513
Merged
Merged
Conversation
The remote deployer shipped only apps/web and built from it, but the web Containerfile expects the apps/ context (desktop-runtime and web/ paths), as CI and check-podman-images.sh use. Ship apps/web, apps/desktop-runtime and apps/.dockerignore, and build with -f web/Containerfile. Set COPYFILE_DISABLE=1 on both remote tar invocations so macOS tar does not add AppleDouble ._* files that break the kickstart JSON parsing. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Without --no-xattrs, bsdtar still writes LIBARCHIVE/SCHILY xattr headers for every file, which GNU tar on the remote host reports as unknown extended header keywords. The test now also pins the apps/ extraction layout (--strip-components=1) the -f web/Containerfile build relies on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018KZHH5VXxZa7mcidXRJdYE
Contributor
Author
albertoperdomo2
approved these changes
Oct 30, 2026
albertoperdomo2
left a comment
albertoperdomo2
left a comment
Contributor
There was a problem hiding this comment.
Approving. The remote build now uses the apps/ context that apps/web/Containerfile needs: desktop-runtime, web/ and .dockerignore sit at the context root, the same layout CI (build-push.yml) and scripts/check-podman-images.sh use. COPYFILE_DISABLE=1 tar --no-xattrs keeps macOS ._* files and xattrs out of both remote archives.
FocusScope dispatches its unmount event from a setTimeout(0). When the shell test file is the last one in its worker, that timer fired after Vitest restored Node's CustomEvent, raising an unhandled dispatchEvent error that failed the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WEB_IMAGE=arche-web:latest ./infra/deploy/deploy.sh ...(build the web image on the VPS) has been broken since #488:prepare_remote_web_imageshipped onlyapps/weband built it as the context, butapps/web/Containerfileexpects theapps/context (COPY desktop-runtime /desktop-runtime,COPY web/...), like CI (context: apps) andscripts/check-podman-images.sh. The build failed withCOPY desktop-runtime ... no such file or directory.._*files; the Next build then parsed._ads-scripts.jsonand failed withInvalid JSON in kickstart agent definition/Failed to collect page data for /api/internal/desktop/kickstart/catalog.Fix
apps/web,apps/desktop-runtimeandapps/.dockerignore, extract them as theapps/context and build withpodman build -f web/Containerfile. Shipping.dockerignorekeeps a dirty local checkout'snode_modules/.nextout of the image.COPYFILE_DISABLE=1 tar --no-xattrsfor both remote archives (web and workspace image), so no._*files or macOS xattr headers reach the remote host. Both are harmless with GNU tar.apps/web/tests/dev-scripts.test.ts(fails before the fix), including the--strip-components=1layout.Not changed: the remote build still runs as the SSH user (rootless podman store), and the upload still includes
node_modulesbefore.dockerignorefilters it on the host.Verification
pnpm test tests/dev-scripts.test.ts9/9,bash -n infra/deploy/deploy.sh,scripts/check-podman-images.shpassed. A real remote deploy from macOS built the web image on the host and completed (failed=0). Reviewed by an independent adversarial review.🤖 Generated with Claude Code