OCTO-11500-Harden-the-WebVTT-reader-against-malformed-input#385
Merged
Conversation
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
lorandvarga
approved these changes
Jul 9, 2026
panasicov
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-->crashing the parser, and numeric character entities passed through as literal textcheck-vtt-complianceskill to reflect current code state after OCTO-11115 (inline tags) and OCTO-11116 (cue settings + STYLE blocks) — eliminates false positives from stale detection patternsChanges
detect()"WEBVTT" in content(matches anywhere)detect()andread()-->in_note_blockstate in all 3 parse methods-->©/♫html.unescape()decodes all entitiesBehavioral note:
now decodes to U+00A0 (non-breaking space) per spec, not U+0020 (regular space). This is more correct but differs from prior behavior.Test plan
pytest tests/ -q)TestWebVTTInputValidationclass covers all 5 fixes (18 test cases)