OCTO-11116 #384
Merged
Merged
Conversation
…ructured Layout geometry at read time. Parse ::cue CSS rules from STYLE blocks and resolve class-based styling onto <c.classname> spans with correct cascade (::cue < ::cue(.class)). Add WritingDirectionEnum to geometry and filter ::cue-prefixed keys from DFXP/SAMI writers.
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
dianadersedan
approved these changes
Jul 9, 2026
lorandvarga
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<c.classname>spans at read time with correct cascade (::cue < ::cue(.class))Production safety
These changes do not affect current production flows (SCC → all output formats):
CaptionSet.get_style("::cue")returns{}for non-VTT sources, so style resolution is a no-opserialized()tuple adds a trailingNonefor writing_direction on SCC/DFXP sources — equality/hash behavior is unchanged::cue-prefixed style keys