Share fixtures across language binding tests - #1866
Draft
chavic wants to merge 1 commit into
Draft
Conversation
Keep common PSBT and OHTTP vectors in one source so Rust and the Python, Dart, JavaScript, and C# tests cannot drift independently. Preserve the existing PSBT constants and document the fixed OHTTP vector separately from keys used for request decryption. Seed Dart's native wrapper from the maintained lockfile so test builds retain dependency versions compatible with the MSRV.
Collaborator
Coverage Report for CI Build 34217292992Coverage increased (+0.004%) to 86.644%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding tests duplicate PSBT and OHTTP data across languages. Store the existing vectors in
payjoin-test-utils/fixturesand load the same files from Rust, Python, Dart, JavaScript, and C# so fixture updates have one source.Preserve the five existing Rust PSBT constants with
include_str!, including the intentionally invalid input. Add test-local loaders, include fixtures in Nix's source filter and C# test output, and check that the fixed OHTTP vector decodes and re-encodes correctly. The fixed OHTTP vector remains separate from the deterministic key/server pair used by request-decryption tests. No new FFI exports or dependencies are introduced.Seed the Dart native wrapper from the maintained lockfile as well. Its previous fresh resolution selected
encoding_rs0.8.40 (Rust 1.88) in the Rust 1.85 test shell, preventing the binding tests from running.Addresses the PSBT/OHTTP portion of #1199. URI literals and test-service namespacing remain separate follow-ups.
Disclosure: co-authored by Codex
Pull Request Checklist