Build Javascript Bindings in Release Mode - #1865
Merged
Merged
Conversation
xstoicunicornx
requested review from
DanGould,
benalleng and
spacebear21
as code owners
September 7, 2026 23:16
xstoicunicornx
force-pushed
the
js-release-mode
branch
from
September 7, 2026 23:22
21a5284 to
2c617ae
Compare
Collaborator
Coverage Report for CI Build 34275112332Coverage increased (+0.03%) to 86.64%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
previously approved these changes
Sep 8, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
cACK - I wonder if it's worth making release builds toggle-able or separate commands, so that dev mode can still be used for quicker debugging/tests/CI?
Collaborator
Author
|
Updated with commands for debug builds. |
xstoicunicornx
force-pushed
the
js-release-mode
branch
from
September 8, 2026 20:29
9c13cbb to
4b70dd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Javascript bindings build to use release mode rather than debug mode.
Also includes a small fix up to remove a redundant command for building the Javascript bindings in CONTRIBUTING.md.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.