Skip to content

chore: update flake.lock #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 2 commits into from
Aug 13, 2026
Merged

chore: update flake.lock #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00cc66
Allow double must_use lint
benalleng Aug 13, 2026
ff34866
chore: update flake.lock
github-actions[bot] Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions payjoin-cli/src/app/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ pub(crate) mod v1;
pub(crate) mod v2;

#[async_trait::async_trait]
// [TODO] remove this clippy ignore once https://github.com/dtolnay/async-trait/pull/303 is included
// in a new release
#[allow(clippy::double_must_use)]

@spacebear21 spacebear21 Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be fixed upstream in the async_trait crate perhaps?

@benalleng benalleng Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be fixed in the next release dtolnay/async-trait#303

@benalleng benalleng Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add a TODO pointing out this is waiting on an upstream fix

pub trait App: Send + Sync {
async fn new(config: Config) -> Result<Self>
where
Expand Down
3 changes: 3 additions & 0 deletions payjoin-ffi/src/receive/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,9 @@ impl payjoin::persist::SessionPersister for CallbackPersisterAdapter {
/// Async session persister that should save and load events as JSON strings.
#[uniffi::export(with_foreign)]
#[async_trait::async_trait]
// [TODO] remove this clippy ignore once https://github.com/dtolnay/async-trait/pull/303 is included
// in a new release
#[allow(clippy::double_must_use)]
pub trait JsonReceiverSessionPersisterAsync: Send + Sync {
async fn save(&self, event: String) -> Result<(), ForeignError>;
async fn load(&self) -> Result<Vec<String>, ForeignError>;
Expand Down
3 changes: 3 additions & 0 deletions payjoin-ffi/src/send/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,9 @@ impl payjoin::persist::SessionPersister for CallbackPersisterAdapter {
/// Async session persister that should save and load events as JSON strings.
#[uniffi::export(with_foreign)]
#[async_trait::async_trait]
// [TODO] remove this clippy ignore once https://github.com/dtolnay/async-trait/pull/303 is included
// in a new release
#[allow(clippy::double_must_use)]
pub trait JsonSenderSessionPersisterAsync: Send + Sync {
async fn save(&self, event: String) -> Result<(), ForeignError>;
async fn load(&self) -> Result<Vec<String>, ForeignError>;
Expand Down
Loading