Skip to content

Use a single release environment for publishing - #1806

Merged
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:unify-release-env
Aug 12, 2026
Merged

Use a single release environment for publishing#1806
spacebear21 merged 1 commit into
payjoin:masterfrom
spacebear21:unify-release-env

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

The crates.io and nuget.org publish jobs each gated on their own GitHub Actions environment, crates-release and nuget-release, with the same purpose: a required-reviewer approval before anything reaches a registry. Before we start adding trusted publishing for more languages/package managers, unify the environment so that this configuration lives in one place.

Co-authored-by: Claude Fable 5

Pull Request Checklist

Please confirm the following before requesting review:

The crates.io and nuget.org publish jobs each gated on their own
GitHub Actions environment, crates-release and nuget-release, with
the same purpose: a required-reviewer approval before anything
reaches a registry. Before we start adding trusted publishing for more
languages/package managers, unify the environment so that this
configuration lives in one place.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 31508793982

Coverage remained the same at 86.718%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16458
Covered Lines: 14272
Line Coverage: 86.72%
Coverage Strength: 343.7 hits per line

💛 - Coveralls

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a4dd4e4

Looks like the new "release" release env is ready to go. Should we delete the other 2 after this merges?

@spacebear21
spacebear21 merged commit f4f3114 into payjoin:master Aug 12, 2026
37 checks passed
@spacebear21

Copy link
Copy Markdown
Collaborator Author

yes, i'll also delete the trusted publishing policies linked to those environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants