Remove utxos_to_be_locked - #1719
Merged
Merged
Conversation
This getter is a vestige of the original bip78 typestate design, in which UnlockedProposal::utxos_to_be_locked() paired with assume_locked() to force integrators to lock the proposal's inputs before a usable Proposal could be obtained. The assume_locked() gate was dropped in 97f0aa2, leaving an optional getter with no enforcement behind it. The outpoints it returns are also of no use to the receiver by the time PayjoinProposal is reached. The receiver's own contributed inputs were hand-picked in contribute_inputs, so the caller already knows them, and the sender's inputs are not the receiver's to lock. The probing defense this method was originally tied to is handled by check_no_inputs_seen_before at the start of the flow.
Collaborator
Coverage Report for CI Build 29027421375Coverage increased (+0.03%) to 86.003%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
approved these changes
Jul 9, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1568
This getter is a vestige of the original bip78 typestate design, in which UnlockedProposal::utxos_to_be_locked() paired with assume_locked() to force integrators to lock the proposal's inputs before a usable Proposal could be obtained. The assume_locked() gate was dropped in 97f0aa2, leaving an optional getter with no enforcement behind it.
The outpoints it returns are also of no use to the receiver by the time PayjoinProposal is reached. The receiver's own contributed inputs were hand-picked in contribute_inputs, so the caller already knows them, and the sender's inputs are not the receiver's to lock. The probing defense this method was originally tied to is handled by
check_no_inputs_seen_before at the start of the flow.
Co-authored by Claude Opus 4.8
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.