Install and configure Rubocop

.rubocop.yml

@@ -0,0 +1,75 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  Exclude:
+    - gemfiles/*
+  NewCops: enable
+  TargetRubyVersion: 2.5
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - spec/**/*
+Lint/EmptyClass:
+  Exclude:
+    - spec/**/*
+Lint/Void:
+  Exclude:
+    - features/step_definitions/object_verification_steps.rb
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*
+
+Naming/MethodName:
+  Exclude:
+    - lib/fabrication.rb
+Naming/PredicateName:
+  Exclude:
+    - lib/fabrication/cucumber/step_fabricator.rb
+
+RSpec/ExampleLength:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/NestedGroups:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: False
+Metrics/ClassLength:
+  Enabled: False
+Metrics/CyclomaticComplexity:
+  Enabled: False
+Metrics/MethodLength:
+  Enabled: False
+Metrics/PerceivedComplexity:
+  Enabled: False
+RSpec/ImplicitExpect:
+  Enabled: False
+RSpec/ImplicitSubject:
+  Enabled: False
+RSpec/LeakyConstantDeclaration:
+  Enabled: False
+RSpec/MessageSpies:
+  Enabled: False
+RSpec/StubbedMock:
+  Enabled: False
+RSpec/VerifiedDoubles:
+  Enabled: False
+Style/ClassAndModuleChildren:
+  Enabled: False
+Style/MissingRespondToMissing:
+  Enabled: False
+Style/ModuleFunction:
+  Enabled: False
+Style/MultilineBlockChain:
+  Enabled: False
+Style/MutableConstant:
+  Enabled: False

Appraisals

@@ -9,6 +9,7 @@ appraise 'kitchen-sink' do
 end
 
 appraise 'blank-slate' do
+  # this simulates requiring fabrication with no known frameworks present
 end
 
 appraise 'rails-6.1' do

Gemfile

@@ -9,4 +9,6 @@ gem 'pry'
 gem 'rake'
 gem 'rspec'
 gem 'rspec-its'
+gem 'rubocop-rake', require: false
+gem 'rubocop-rspec', require: false
 gem 'sqlite3'

Gemfile.lock

@@ -10,6 +10,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.4.2)
     backports (3.8.0)
     builder (3.2.3)
     coderay (1.1.2)
@@ -35,10 +36,16 @@ GEM
     method_source (0.9.0)
     multi_json (1.12.2)
     multi_test (0.1.2)
+    parallel (1.20.1)
+    parser (3.0.0.0)
+      ast (~> 2.4.1)
     pry (0.11.1)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    rainbow (3.0.0)
     rake (12.1.0)
+    regexp_parser (2.1.1)
+    rexml (3.2.4)
     rspec (3.6.0)
       rspec-core (~> 3.6.0)
       rspec-expectations (~> 3.6.0)
@@ -55,8 +62,26 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
+    rubocop (1.11.0)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-rake (0.5.1)
+      rubocop
+    rubocop-rspec (2.2.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
     sqlite3 (1.3.13)
     thor (0.20.0)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   ruby
@@ -70,6 +95,8 @@ DEPENDENCIES
   rake
   rspec
   rspec-its
+  rubocop-rake
+  rubocop-rspec
   sqlite3
 
 BUNDLED WITH

Rakefile

@@ -1,20 +1,18 @@
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
 Bundler.require
 
-require "rspec/core/rake_task"
+require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |spec|
-  spec.pattern = "spec/**/*_spec.rb"
+  spec.pattern = 'spec/**/*_spec.rb'
 end
 
 desc 'All cucumber features with kitchen sink appraisal'
 task :cucumber do
   system('appraisal kitchen-sink cucumber -f progress')
 end
 
-if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
-  task default: [:cucumber, :appraisal]
-else
-  task default: :spec
-end
+default_task = !ENV['APPRAISAL_INITIALIZED'] && !ENV['TRAVIS'] ? %i[cucumber appraisal] : :spec
+
+task default: default_task

fabrication.gemspec

@@ -1,25 +1,25 @@
-# -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib/', __FILE__)
-$:.unshift lib unless $:.include?(lib)
+lib = File.expand_path('lib', __dir__)
+$LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
 
 require 'fabrication/version'
 
 Gem::Specification.new do |s|
-  s.name = "fabrication"
+  s.name = 'fabrication'
   s.version = Fabrication::VERSION
-  s.license = "MIT"
+  s.license = 'MIT'
 
-  s.authors = ["Paul Elliott"]
-  s.email = ["paul@codingfrontier.com"]
-  s.description = "Fabrication is an object generation framework for ActiveRecord, Mongoid, DataMapper, Sequel, or any other Ruby object."
+  s.authors = ['Paul Elliott']
+  s.email = ['paul@codingfrontier.com']
+  s.description = 'Fabrication is an object generation framework for ActiveRecord, ' \
+                  'Mongoid, DataMapper, Sequel, or any other Ruby object.'
 
-  s.homepage = "http://fabricationgem.org"
-  s.require_paths = ["lib"]
-  s.rubygems_version = "1.3.7"
+  s.homepage = 'http://fabricationgem.org'
+  s.require_paths = ['lib']
+  s.rubygems_version = '1.3.7'
   s.summary = "Implementing the factory pattern in Ruby so you don't have to."
 
-  s.required_ruby_version = '>= 2.2.0'
+  s.required_ruby_version = '>= 2.5.0'
 
-  s.files = Dir.glob("lib/**/*") + %w(LICENSE README.markdown Rakefile)
+  s.files = Dir.glob('lib/**/*') + %w[LICENSE README.markdown Rakefile]
   s.require_path = 'lib'
 end

features/step_definitions/object_verification_steps.rb

@@ -1,10 +1,10 @@
 ORDINALS = {
-  "first" => 0,
-  "second" => 1
+  'first' => 0,
+  'second' => 1
 }
 
 def dehumanize(string)
-  string.gsub(/\W+/,'_').downcase
+  string.gsub(/\W+/, '_').downcase
 end
 
 def generate_fabricator_name(model_name)
@@ -16,26 +16,25 @@ def get_class(model_name)
   Fabrication.manager[fabricator_name].send(:klass)
 end
 
-
-Then /^that ([^"]*) should be persisted$/ do |object_name|
+Then(/^that ([^"]*) should be persisted$/) do |object_name|
   object_name = dehumanize(object_name)
   object = fabrications[object_name]
   object.should be_persisted
 end
 
-Then /^that ([^"]*) should have "([^"]*)" for a "([^"]*)"$/ do |object_name, value, field|
+Then(/^that ([^"]*) should have "([^"]*)" for a "([^"]*)"$/) do |object_name, value, field|
   object_name = dehumanize(object_name)
   object = fabrications[object_name]
   object.send(dehumanize(field)).to_s.should == value
 end
 
-Then /^they should be persisted$/ do
+Then(/^they should be persisted$/) do
   @they.each do |object|
     object.should be_persisted
   end
 end
 
-Then /^they should reference that ([^"]*)$/ do |parent_name|
+Then(/^they should reference that ([^"]*)$/) do |parent_name|
   parent_name = dehumanize(parent_name)
   parent = fabrications[parent_name]
   parent_class = get_class(parent_name)
@@ -46,12 +45,12 @@ def get_class(model_name)
   end
 end
 
-Then /^the ([^"]*) should have "([^"]*)" for a "([^"]*)"$/ do |ordindal, value, field|
+Then(/^the ([^"]*) should have "([^"]*)" for a "([^"]*)"$/) do |ordindal, value, field|
   object = @they[ORDINALS[ordindal]]
   object.send(dehumanize(field)).to_s.should == value
 end
 
-Then /^that ([^"]*) should reference that ([^"]*)$/ do |child_name, parent_name|
+Then(/^that ([^"]*) should reference that ([^"]*)$/) do |child_name, parent_name|
   parent_name = dehumanize(parent_name)
   parent = fabrications[parent_name]
   parent_class = get_class(parent_name)
@@ -61,7 +60,7 @@ def get_class(model_name)
   child.send(parent_class_name).should == parent
 end
 
-Then /^that (.*) should have (\d+) (.*)$/ do |parent_name, count, child_name|
+Then(/^that (.*) should have (\d+) (.*)$/) do |parent_name, count, child_name|
   parent_name = dehumanize(parent_name)
   parent = fabrications[parent_name]
   parent.send(dehumanize(child_name).pluralize).count.should == count.to_i

features/step_definitions/other_steps.rb

@@ -1,11 +1,9 @@
-When /^I try to fabricate "([^"]*)"$/ do |fabricator_name|
+When(/^I try to fabricate "([^"]*)"$/) do |fabricator_name|
   @fabricator_name = fabricator_name
 end
 
-Then /^it should tell me that it isn't defined$/ do
-  begin
-    step "1 #{@fabricator_name}"
-  rescue Exception => e
-    e.message.should == "No Fabricator defined for '#{@fabricator_name}'"
-  end
+Then(/^it should tell me that it isn't defined$/) do
+  step "1 #{@fabricator_name}"
+rescue StandardError => e
+  e.message.should == "No Fabricator defined for '#{@fabricator_name}'"
 end

features/support/env.rb

@@ -2,7 +2,9 @@
 
 Bundler.require(:default, :development)
 
-Dir[File.expand_path(File.join(File.dirname(__FILE__),'..','..','spec','support','**','*.rb'))].each {|f| require f}
+Dir[File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'spec', 'support', '**', '*.rb'))].sort.each do |f|
+  require f
+end
 load 'lib/rails/generators/fabrication/cucumber_steps/templates/fabrication_steps.rb'
 
 Before do

lib/fabricate.rb

@@ -1,51 +1,48 @@
 class Fabricate
-  def self.times(count, name, overrides={}, &block)
+  def self.times(count, name, overrides = {}, &block)
     count.times.map { Fabricate(name, overrides, &block) }
   end
 
-  def self.build_times(count, name, overrides={}, &block)
+  def self.build_times(count, name, overrides = {}, &block)
     count.times.map { Fabricate.build(name, overrides, &block) }
   end
 
-  def self.attributes_for_times(count, name, overrides={}, &block)
+  def self.attributes_for_times(count, name, overrides = {}, &block)
     count.times.map { Fabricate.attributes_for(name, overrides, &block) }
   end
 
-  def self.attributes_for(name, overrides={}, &block)
+  def self.attributes_for(name, overrides = {}, &block)
     fail_if_initializing(name)
     schematic(name).to_attributes(overrides, &block)
   end
 
-  def self.to_params(name, overrides={}, &block)
+  def self.to_params(name, overrides = {}, &block)
     fail_if_initializing(name)
     schematic(name).to_params(overrides, &block)
   end
 
-  def self.build(name, overrides={}, &block)
+  def self.build(name, overrides = {}, &block)
     fail_if_initializing(name)
     schematic(name).build(overrides, &block).tap do |object|
       Fabrication::Cucumber::Fabrications[name] = object if Fabrication::Config.register_with_steps?
     end
   end
 
-  def self.create(name, overrides={}, &block)
+  def self.create(name, overrides = {}, &block)
     fail_if_initializing(name)
     schematic(name).fabricate(overrides, &block)
   end
 
-  def self.sequence(name=Fabrication::Sequencer::DEFAULT, start=nil, &block)
+  def self.sequence(name = Fabrication::Sequencer::DEFAULT, start = nil, &block)
     Fabrication::Sequencer.sequence(name, start, &block)
   end
 
   def self.schematic(name)
     Fabrication.manager.load_definitions if Fabrication.manager.empty?
-    Fabrication.manager[name] || raise(Fabrication::UnknownFabricatorError.new(name))
+    Fabrication.manager[name] || raise(Fabrication::UnknownFabricatorError, name)
   end
 
-  private
-
   def self.fail_if_initializing(name)
-    raise Fabrication::MisplacedFabricateError.new(name) if Fabrication.manager.initializing?
+    raise Fabrication::MisplacedFabricateError, name if Fabrication.manager.initializing?
   end
-
 end

lib/fabrication.rb

@@ -52,16 +52,17 @@ def self.manager
   end
 
   def self.schematics
-    puts "DEPRECATION WARNING: Fabrication.schematics has been replaced by Fabrication.manager and will be removed in 3.0.0."
+    puts 'DEPRECATION WARNING: Fabrication.schematics has been replaced by Fabrication.manager' \
+      ' and will be removed in 3.0.0.'
     manager
   end
 end
 
-def Fabricator(name, options={}, &block)
+def Fabricator(name, options = {}, &block)
   Fabrication.manager.register(name, options, &block)
 end
 
-def Fabricate(name, overrides={}, &block)
+def Fabricate(name, overrides = {}, &block)
   Fabricate.create(name, overrides, &block).tap do |object|
     Fabrication::Cucumber::Fabrications[name] = object if Fabrication::Config.register_with_steps?
   end