Skip to content

Addressing formatting issues for currency PR #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickloughrey merged 1 commit into from
Jul 22, 2026
Merged

Addressing formatting issues for currency PR #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions adapters/triplelift/triplelift.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ func processImp(imp *openrtb2.Imp, reqInfo *adapters.ExtraRequestInfo) error {
imp.TagID = tlext.InvCode
// floor is optional
if tlext.Floor != nil {
imp.BidFloor = *tlext.Floor
}
// Normalize bid floor to USD - TLX expects USD
imp.BidFloor = *tlext.Floor
}
// Normalize bid floor to USD - TLX expects USD
if err := resolveBidFloorCurrency(imp, reqInfo); err != nil {
return err
}
Expand Down Expand Up @@ -147,8 +147,8 @@ func (a *TripleliftAdapter) MakeBids(internalRequest *openrtb2.BidRequest, exter
count := getBidCount(bidResp)
bidResponse := adapters.NewBidderResponseWithBidsCapacity(count)

// Bids are always denominated in USD
bidResponse.Currency = "USD"
// Bids are always denominated in USD
bidResponse.Currency = "USD"

for _, sb := range bidResp.SeatBid {
for i := 0; i < len(sb.Bid); i++ {
Expand Down
4 changes: 2 additions & 2 deletions adapters/triplelift/triplelift_currency_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ var currencyTestCases = map[string]struct {
assertError: assert.NoError,
},
"usd lowercase - no conversion needed": {
imp: openrtb2.Imp{BidFloor: 2.0, BidFloorCur: "usd"},
setMock: func(m *mock.Mock) {},
imp: openrtb2.Imp{BidFloor: 2.0, BidFloorCur: "usd"},
setMock: func(m *mock.Mock) {},
expectedImp: openrtb2.Imp{BidFloor: 2.0, BidFloorCur: "USD"},
assertError: assert.NoError,
},
Expand Down
4 changes: 2 additions & 2 deletions adapters/triplelift_native/triplelift_native.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@ func processImp(imp *openrtb2.Imp, request *openrtb2.BidRequest, reqInfo *adapte
imp.TagID = tlext.InvCode
}

// floor is optional
// floor is optional
if tlext.Floor != nil {
imp.BidFloor = *tlext.Floor
}

// Normalize bid floor to USD
// Normalize bid floor to USD
if err := resolveBidFloorCurrency(imp, reqInfo); err != nil {
return err
}
Expand Down
Loading