fix: do not resolve documented subpath patterns as filenames - #210
Merged
Conversation
Second false failure from the gate, again blocking 1.3.0. The README ends its subpath section with Also `@pathscale/ui/hooks/*` and `@pathscale/ui/styles/*`. which is prose describing a family of subpaths. The scanner treated both as import specifiers and tried to resolve the literal asterisk, looking for ./dist/hooks/*/index.js as a filename. A specifier containing `*` is now checked against the exports keys rather than the filesystem. The exports loop already proved both directories ship, which is why only the README half failed. Verified against the published 1.2.11 tarball (still reports the stale ./stores export and the missing stylesheet) and against master's real README and exports (passes). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
🚀 Preview deployment is ready! You can view the preview at: https://pr-ui-preview-210.surge.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second false failure from my gate, again blocking 1.3.0. A real assertion this time rather than a crash, but still wrong.
The README ends its subpath section with:
That is prose describing a family of subpaths. The scanner treated both as import specifiers and tried to resolve the literal asterisk as a path — looking for
./dist/hooks/*/index.jsas a filename.Specifiers containing
*are now validated against theexportskeys instead of the filesystem. The exports loop passed on both, which is how we knowdist/hooks/anddist/styles/genuinely ship — only the README half was wrong.Verified both directions
./storesexport and the README's missing stylesheethooks/andstyles/→ passesState
master is 1.3.0, npm is 1.2.11. Recovery mode publishes a version not yet on npm, so merging this triggers the 1.3.0 publish.
🤖 Generated with Claude Code