317 ci tests are failing because ffmpeg installation does not work#318
Merged
M-Lampert merged 4 commits intoJul 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows and the shared setup composite action, aiming to stabilize CI by fixing how ffmpeg is installed and refreshing several action dependencies.
Changes:
- Bumped
tj-actions/changed-filesfromv42tov47across CI workflows. - Updated the shared setup composite action to newer
setup-uv,actions/cache, and TeX Live action versions. - Replaced
setup-ffmpegwith installingffmpegvia apt packages in the setup action.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/testing.yml | Updates changed-files action version used to gate running tests. |
| .github/workflows/notebook_testing.yml | Updates changed-files action version used to gate notebook tests. |
| .github/workflows/docstring_testing.yml | Updates changed-files action version used to gate docstring tests. |
| .github/actions/setup/action.yml | Updates setup actions and switches ffmpeg installation to apt-based install. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
20
to
23
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v42 | ||
| uses: tj-actions/changed-files@v47 | ||
| with: |
Comment on lines
18
to
22
| # Only run workflow if certain files have been changed. | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v42 | ||
| uses: tj-actions/changed-files@v47 | ||
| with: |
Comment on lines
18
to
22
| # Only run workflow if certain files have been changed. | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v42 | ||
| uses: tj-actions/changed-files@v47 | ||
| with: |
Comment on lines
23
to
27
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v6 | ||
| uses: astral-sh/setup-uv@v8.3.2 | ||
| with: | ||
| python-version: ${{ inputs.python-version }} | ||
| activate-environment: true |
Comment on lines
47
to
52
| - name: Set up TeX Live | ||
| if: ${{ inputs.full_install == 'true' }} | ||
| uses: TeX-Live/setup-texlive-action@v3 | ||
| uses: TeX-Live/setup-texlive-action@v4 | ||
| with: | ||
| cache: true | ||
| packages: | |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
M-Lampert
deleted the
317-ci-tests-are-failing-because-ffmpeg-installation-does-not-work
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ffmpeg installation