docs: documentar validacao com testcontainers e politica de retencao no readme - #14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3de5dcf6ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Run Testcontainers validation suite | ||
| python3 -m unittest tests/test_container.py -v |
There was a problem hiding this comment.
Make failed container setup fail the documented validation
When Docker is unavailable—or the image build itself raises—this command reports success without validating anything: tests/test_container.py converts both an unavailable daemon and every image-build error into SkipTest, so unittest exits 0 with OK (skipped=1). A broken Dockerfile can therefore appear to pass the newly documented image validation; require Docker/build failures to fail, or document the prerequisite and how to reject a skipped suite.
Useful? React with 👍 / 👎.
|
|
||
|
|
||
| Official multi-architecture Docker images (`linux/amd64` and `linux/arm64`) are published automatically to the GitHub Container Registry (GHCR): | ||
| Official multi-architecture Docker images (`linux/amd64` and `linux/arm64`) are published automatically to the GitHub Container Registry (GHCR) on pushes to `master` with changes in `src/`. An automated retention policy maintains strictly the last 3 versions: |
There was a problem hiding this comment.
Avoid promising an exact three-version retention count
The policy does not strictly cap the registry at three versions: both cleanup workflows set keep-n-tagged: 3 while excluding latest, and cleanup-packages.yml explicitly notes that latest is outside that count. After successive builds, the protected latest digest can therefore coexist with three additional tagged versions, so operators relying on this statement for storage or rollback expectations get the wrong limit; describe the policy as latest plus the retained tagged versions, or change the workflow to enforce an actual total of three.
Useful? React with 👍 / 👎.
Atualiza o README.md com a documentacao de execucao dos testes com Testcontainers (Option 3) e as informacoes sobre a publicacao automatica no GitHub Packages e politica de retencao das 3 ultimas versoes.