Repository navigation
refactor: Bump handlebars from 4.7.9 to 4.7.10 - #628
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 7 minutes. View limit details
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 11 11
Lines 1841 1841
=======================================
Hits 1826 1826
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This change has been released in version 8.5.7 |
Closes #624
Changes
Security update of a transitive, development-only dependency (lock file only).
handlebarsis only used by the release tooling (conventional-changelog-writer@8.0.0via@semantic-release/release-notes-generatorand@semantic-release/commit-analyzer); it is not part of the published package.compile) and GHSA-xw65-4hp5-5hc7 (medium, JavaScript injection via unsafe inline embedding of precompiled templates). Further hardening: sanitize the source map URL when minifying, iterate lazily in#eachand strip whitespace in linear time, only compile partials that are template strings, only dispatch known AST node types. Bumps its ownminimistdependency to^1.2.8(handlebars-lang/handlebars.js@ea8ed82).{{#each}}now iterates iterables such asMap,Setand generators lazily instead of copying them into an array first.Lock file side effect: the hoisted
minimistmoves from 1.2.6 to 1.2.8 to satisfy the new range (Dependabot's branch for #624 contains the same change). The other dependents' ranges are still satisfied:web-push(^1.2.5, production) andrc(^1.2.0, dev).web-pushonly usesminimistin its CLI (src/cli.js), which this adapter does not load. minimist 1.2.7 contains only tooling changes; 1.2.8 fixes argument-parsing edge cases.Breaking Changes
None
Code Changes Required
None — the upgrade is a drop-in replacement.
conventional-changelog-writerregisters the.releaserc/*.hbspartials as strings, compiles withnoEscape: trueand passes arrays to#each, so the 4.7.10 changes do not apply. Release notes rendered from this repository's.releaserc.jsand templates (480 commits ofmasterplus synthetic commits with notes, scopes, references and reverts; 6 scenarios) are byte-identical on 4.7.9 and 4.7.10.